Port motion_control_handle to Jazzy
#214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zixingjiang
changed the title
motion_control__handle to Jazzymotion_control_handle to Jazzy
|
Thanks @zixingjiang for spotting this and for the PR! |
stefanscherzinger
merged commit 2a0268a
into
fzi-forschungszentrum-informatik:ros2
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @stefanscherzinger,
Thank you for porting cartesian_controllers to Jazzy. After trying it out, I found the
motion_control_handlewas left out. It still tries to getrobot_descriptionfrom the parameter, which is deprecated. To fix it, this PR let themotion_control_handlegetrobot_descriptionfrom the controller's base class for Jazzy, as done in cartesian_controller_base.cpp.