Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeatexplorer #89

Merged
merged 25 commits into from
Nov 2, 2023
Merged

Conversation

TomHarrop
Copy link
Contributor

No description provided.

@TomHarrop TomHarrop marked this pull request as draft November 1, 2023 12:54
@TomHarrop
Copy link
Contributor Author

I've done this to avoid all the cp commands in the original wrapper, but I think this means it's writing directly to the output directory? Let me know if there's a better way to pick up the additional content for the html file.

--output_dir=${ReportFile.extra_files_path}

@bgruening
Copy link
Contributor

I've done this to avoid all the cp commands in the original wrapper, but I think this means it's writing directly to the output directory? Let me know if there's a better way to pick up the additional content for the html file.

--output_dir=${ReportFile.extra_files_path}

I guess that's fine if really ALL files are needed in this HTML output. If not the cp or mv might actually a more explicit way to do.

@TomHarrop
Copy link
Contributor Author

I've done this to avoid all the cp commands in the original wrapper, but I think this means it's writing directly to the output directory? Let me know if there's a better way to pick up the additional content for the html file.

--output_dir=${ReportFile.extra_files_path}

I guess that's fine if really ALL files are needed in this HTML output. If not the cp or mv might actually a more explicit way to do.

Yep. I doubt they are all needed but I don't think it will be quick to work out exactly which ones are.

@TomHarrop TomHarrop changed the title WIP /draft Repeatexplorer Repeatexplorer Nov 2, 2023
@TomHarrop TomHarrop marked this pull request as ready for review November 2, 2023 09:37
@@ -0,0 +1,11 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you convert that to a suite of tools?
In the original repo there have been two tools at least isn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I converted it to a suite.

BTW @bgruening it looked to me like the second wrapper runs the same command as the first with an additional option tarean_mode, so we can just include that function in this wrapper if we want it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(probably)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, lets do that then. In general a suite can not hurt, so its fine to have it as suite in case we ever want to extend it. Thanks

tools/repeatexplorer2/repex_full_clustering.xml Outdated Show resolved Hide resolved
tools/repeatexplorer2/repex_full_clustering.xml Outdated Show resolved Hide resolved

]]></command>
<inputs>
<param name="FastaFile" label="NGS reads" type="data" format="fasta" help="Input file must contain FASTA-formatted NGS reads. Illumina paired-end reads are recommended."/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep the names all lower case?

<inputs>
<param name="FastaFile" label="NGS reads" type="data" format="fasta" help="Input file must contain FASTA-formatted NGS reads. Illumina paired-end reads are recommended."/>
<param argument="--paired" type="boolean" truevalue="--paired" falsevalue="" checked="True" label="Paired-end reads" help="If paired-end reads are used, they must be interleaved and all pairs must be complete. Example of the correct format is provided in the help below."/>
<param argument="--sample" type="integer" optional="true" label="Subsample reads (number)" help="Use an integer &gt; 1 to select a specific number of reads to use. Leave this field blank to use the entire dataset."/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add min=2?

tools/repeatexplorer2/repex_full_clustering.xml Outdated Show resolved Hide resolved
tools/repeatexplorer2/repex_full_clustering.xml Outdated Show resolved Hide resolved
tools/repeatexplorer2/repex_full_clustering.xml Outdated Show resolved Hide resolved
@bgruening bgruening merged commit 5da32fe into galaxy-genome-annotation:master Nov 2, 2023
10 checks passed
@bgruening
Copy link
Contributor

Thanks @TomHarrop

@TomHarrop TomHarrop deleted the repeatexplorer branch November 2, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants