Shutdown explicitly while existing

[evshary]

🦟 Bug fix

Summary

Shutdown explicitly after creating an entity.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[caguero]

Just checking, do we need to call shutdown() before the previous return calls as well?

[evshary]

Just checking, do we need to call shutdown() before the previous return calls as well?

Good catch! I believe it should be.

[Yadunund]

Instead of multiple rclcpp::shutdown() calls, we could wrap this call inside a callback that will automatically execute once the program terminates by relying on rcpputils::make_scope_exit().