Use both ROS package and message name for unique mappings #656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This prepends the ROS package name before the message name to avoid problems with collision when two distinct packages declare the same message name. Any custom message package declaring Imu.msg will not compile as the generated publishers, subscribers, and tests will have the same names in the following files.
Example: custom_msgs/msg/Imu.msg will collide with sensor_msgs/msg/Imu.msg in the declarations of
This commit adds the package name to the unique name generation, such that
auto imu_imu_pub
becomesauto imu_sensor_msgs_imu_pub
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.