refactor(apigateway): authorization models #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roleyfoley
suggested changes
May 21, 2022
|
@roleyfoley I've added prefixed values for the SIG4 models. In a future breaking change, we can remove the non-prefixed ones. I'll rise a ticket to add this to the list for the next breaking change. |
roleyfoley
force-pushed
the
refactor/api-gateway-resource-policies
branch
from
19e6e21 to
daeb3f4
Compare
ml019
force-pushed
the
refactor/api-gateway-resource-policies
branch
from
daeb3f4 to
0b542ab
Compare
Support additional model values for the case of IP filtering in combination with a lambda authorizer. Also rename the config attribute to more correctly reflect its purpose in controlling authorization rather than authentication. When used with a lambda authorizer, the default value of "IP" incorrectly provides an explict ALLOW rather than relying on it to come from the policy provided by the authorizer. By providing explicit values to be used with the authorizer, the configuration can be validated as appropriate.
Force the user to correct misconfigurations of the authorization model if use of authorizers is detected.
Add AWS specific values for authroisation models involving SIG4. This will permit the removal of the non-preofixed versions in a future breaking change.
Move the non-prefixed SIG4 authorization models to the AWS provider as they are very specific to AWS. A future change can remove the non-prefixed ones, though moving them to the AWS provider largely isolates them anyway.
ml019
force-pushed
the
refactor/api-gateway-resource-policies
branch
from
0b542ab to
77d71cf
Compare
roleyfoley
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent of Change
Description
Support additional model values for the case of IP filtering in combination with a lambda authorizer. Also rename the config attribute to more correctly reflect its purpose in controlling authorization rather than authentication.
Motivation and Context
When used with a lambda authorizer, the default value of "IP" incorrectly provides an explicit ALLOW rather than relying on it to come from the policy provided by the authorizer. By providing explicit values to be used with the authorizer, the configuration can be validated as appropriate.
How Has This Been Tested?
Local template generation
Related Changes
Prerequisite PRs:
Dependent PRs:
Consumer Actions: