riscv64: replace deprecated legacy extensions to SBI 2.0 extensions #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkroening
requested changes
Mar 13, 2024
mkroening
requested changes
Apr 16, 2024
The SBI legacy extensions are deprecated 4 years ago ( riscv-non-isa/riscv-sbi-doc@705e955 ). We replace it using functions from SBI 2.0 extensions. Specifically: - the legacy console_putchar is replaced into console_write_byte in SBI DBCN extension; - legacy shutdown is replaced to system_reset in SBI SRST extension with ColdReboot and NoReason as parameters; - legacy set_timer is replaced with SBI TIME set_timer; - legacy send_ipi is replaced to SBI IPI extension. The code implemented in file processor.rs creates a HartMask with only one hart_id selected as an IPI target. Signed-off-by: Zhouqi Jiang <[email protected]>
mkroening
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SBI legacy extensions are deprecated 4 years ago ( riscv-non-isa/riscv-sbi-doc@705e955 ). We replace it using functions from SBI 2.0 extensions. Specifically:
By updating to SBI 2.0, this commit supports to send IPI to hart IDs greater than 63 (on 64-bit devices). The current code encodes hart_id parameter in bit-vector like
1 << hart_id, which will cause the bit to be shifted out fromusizerange whenhart_id >= 64. SBI 2.0 fixed this problem by adding ahart_mask_baseparameter, allowing us to specify any hart ID withinusizerange when is provided as an SBI IPI hart mask.