updates the tx-poller to stream transactions #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 17, 2025
prestwich
requested changes
Mar 17, 2025
prestwich
reviewed
Mar 17, 2025
prestwich
reviewed
Mar 17, 2025
prestwich
reviewed
Mar 17, 2025
dylanlott
force-pushed
the
03-07-updates_the_tx-poller_to_stream_transactions
branch
from
8b1ec06 to
aaeb7c6
Compare
prestwich
reviewed
Mar 19, 2025
dylanlott
force-pushed
the
03-07-updates_the_tx-poller_to_stream_transactions
branch
from
aaeb7c6 to
aff2cdf
Compare
dylanlott
force-pushed
the
03-07-updates_the_tx-poller_to_stream_transactions
branch
from
aff2cdf to
5069931
Compare
prestwich
reviewed
Mar 29, 2025
| tracing::debug!(count = ?transactions.len(), "found transactions"); | ||
| for tx in transactions.into_iter() { | ||
| if let Err(err) = outbound.send(tx) { | ||
| tracing::error!(err = ?err, "failed to send transaction - channel is dropped."); |
There was a problem hiding this comment.
if the listener for the outbound channel is dropped, we want to end this loop. that's how we propagate shutdowns in the actor model, by always exiting when the task can't send messages anymore. This ensures that segments of the program automatically clean themselves up when no longer needed. As written, the loop will continue to run forever even after all of its downstreams are gone
There was a problem hiding this comment.
this is also not an error case, as it's a normal part of the program lifecycle, so trace! would be more appropriate here
- shifts the tx-poller to a more actor oriented approach by streaming transactions out of the cache. - transaction deduplication and validation is intended to be carried out by the simulator.
dylanlott
force-pushed
the
03-07-updates_the_tx-poller_to_stream_transactions
branch
from
5069931 to
1ad6e14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ENG-792