[wip] wires up the block and submit task to use simulation #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 17, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dylanlott
changed the title
dylanlott
force-pushed
the
03-16-adds_simulation_factory_to_builder
branch
from
3e6203e to
33f0c96
Compare
dylanlott
force-pushed
the
03-17-wires_up_the_block_and_submit_task_to_use_simulation
branch
from
fd30611 to
2d031c5
Compare
dylanlott
force-pushed
the
03-16-adds_simulation_factory_to_builder
branch
from
33f0c96 to
0f17597
Compare
dylanlott
force-pushed
the
03-17-wires_up_the_block_and_submit_task_to_use_simulation
branch
from
2d031c5 to
2ca9df1
Compare
dylanlott
force-pushed
the
03-16-adds_simulation_factory_to_builder
branch
from
0f17597 to
c0b070b
Compare
dylanlott
force-pushed
the
03-17-wires_up_the_block_and_submit_task_to_use_simulation
branch
from
2ca9df1 to
25b7e30
Compare
dylanlott
force-pushed
the
03-16-adds_simulation_factory_to_builder
branch
from
c0b070b to
56d569f
Compare
dylanlott
force-pushed
the
03-17-wires_up_the_block_and_submit_task_to_use_simulation
branch
from
25b7e30 to
6fd97a3
Compare
- adds the simulator task to the block building loop - feeds the submit channel to the simulator after in-progress block creation
dylanlott
force-pushed
the
03-16-adds_simulation_factory_to_builder
branch
from
56d569f to
519bad3
Compare
dylanlott
force-pushed
the
03-17-wires_up_the_block_and_submit_task_to_use_simulation
branch
from
6fd97a3 to
a500888
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ENG-640