-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates bundler to streaming actor pattern #61
Open
dylanlott
wants to merge
3
commits into
03-07-updates_the_tx-poller_to_stream_transactions
Choose a base branch
from
03-16-updates_bundler_to_streaming_actor_pattern
base: 03-07-updates_the_tx-poller_to_stream_transactions
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
updates bundler to streaming actor pattern #61
dylanlott
wants to merge
3
commits into
03-07-updates_the_tx-poller_to_stream_transactions
from
03-16-updates_bundler_to_streaming_actor_pattern
+51
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 17, 2025
e815024
to
da16b28
Compare
prestwich
reviewed
Mar 17, 2025
prestwich
reviewed
Mar 17, 2025
prestwich
requested changes
Mar 17, 2025
da16b28
to
6d96ba0
Compare
8b1ec06
to
aaeb7c6
Compare
14c9300
to
154904b
Compare
aaeb7c6
to
aff2cdf
Compare
8ad95f6
to
962eaa1
Compare
aff2cdf
to
5069931
Compare
83382b4
to
47b29f7
Compare
5069931
to
1ad6e14
Compare
47b29f7
to
fa6109b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates builder to streaming actor pattern
The block builder was previously just calling the fetch function from the bundle service. Instead, this PR makes it so that bundles are streamed out from the cache to a simulator task that processes and builds them into a valid block.
Closes ENG-791