Invoicing rate report #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeppekroghitk
changed the base branch from
develop
to
feature/2597-billable-report-expansion
jeppekroghitk
force-pushed
the
feature/2597-add-workload-summary-report
branch
2 times, most recently
from
889d76f to
5cc53d4
Compare
jeppekroghitk
force-pushed
the
feature/2597-add-workload-summary-report
branch
2 times, most recently
from
2e06e3c to
7883be8
Compare
jeppekroghitk
changed the base branch from
feature/2597-billable-report-expansion
to
feature/3489-workload-report-period-average-etc
tuj
requested changes
Jan 3, 2025
| $workerProjects = []; | ||
|
|
||
| foreach ($periods as $period) { | ||
| // Add current period match-point (current week-number, month-number etc.) |
There was a problem hiding this comment.
Please add some more explanation about why it should be 53 when not the current year.
jeppekroghitk
force-pushed
the
feature/3489-workload-report-period-average-etc
branch
3 times, most recently
from
377b748 to
f0f0e4e
Compare
jeppekroghitk
force-pushed
the
feature/2597-add-workload-summary-report
branch
from
dc3b7bf to
b312ec8
Compare
tuj
requested changes
Jan 6, 2025
CHANGELOG.md
Outdated
| @@ -368,10 +370,7 @@ complete process. | |||
| * Updated to authorization code flow. | |||
| * Changed worklog save button styling to be sticky. | |||
|
|
|||
| [Unreleased]: https://github.com/itk-dev/economics/compare/2.5.1...HEAD | |||
| [2.5.1]: https://github.com/itk-dev/economics/compare/2.5.0...2.5.1 | |||
There was a problem hiding this comment.
2.5.1, 2.5.0, 2.4.3 should not be removed
src/Entity/IssueEpic.php
Outdated
Co-authored-by: Troels Ugilt Jensen <[email protected]>
Co-authored-by: Troels Ugilt Jensen <[email protected]>
Co-authored-by: Troels Ugilt Jensen <[email protected]>
Co-authored-by: Troels Ugilt Jensen <[email protected]>
Co-authored-by: Troels Ugilt Jensen <[email protected]>
Co-authored-by: Troels Ugilt Jensen <[email protected]>
tuj
requested changes
Jan 6, 2025
| @@ -58,6 +58,8 @@ public function getWorkloadReport(int $year, PeriodTypeEnum $viewPeriodType = Pe | |||
| $currentPeriodReached = false; | |||
| $expectedWorkloadSum = 0; | |||
| $loggedHoursSum = 0; | |||
| $periodSums = []; | |||
There was a problem hiding this comment.
$periodSums and $periodCounts are not used in the file
tuj
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
2597
Description
This PR builds upon #183 and #184 and introduces a new report containing essentially a summary of what Worklog Report provides, to give a detailed overview of billable hours, percentage of billed hours, as well as the team averages.
Screenshot of the result
N/A
Checklist