Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running multi-language apps #259

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

eemcmullan
Copy link
Collaborator

@eemcmullan eemcmullan commented Jun 13, 2024

  • This PR enables an application consisting of multiple languages to run analysis. By default, it will only run providers we support.
  • Addition of --provider string array flag, which can be used to bypass the default logic to explicitly set which provider(s) to run.
  • Addition of --list-providers flag to list supported providers.
  • Note This is not the same thing as the --overrideProvider option, as it still must be a supported provider.

In draft for more testing

Closes #245
Closes #248
Closes #260

cmd/analyze.go Outdated Show resolved Hide resolved
cmd/analyze.go Outdated Show resolved Hide resolved
}

func (a *analyzeCommand) setProviders(components []model.Component, foundProviders []string) ([]string, error) {
if len(a.provider) > 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont think I completely understood this part.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding provider(s) from --provider to the map instead of allowing language discovery to add them

cmd/analyze.go Outdated Show resolved Hide resolved
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve when it's not in draft. One comment to help make rebase easier.

cmd/analyze.go Outdated Show resolved Hide resolved
@eemcmullan eemcmullan marked this pull request as ready for review June 18, 2024 20:40
@eemcmullan eemcmullan force-pushed the multi-language branch 3 times, most recently from d0f9f73 to 258d0d3 Compare June 20, 2024 16:28
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@pranavgaikwad pranavgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments, otherwise good to merge

Signed-off-by: Emily McMullan <[email protected]>
@eemcmullan eemcmullan merged commit b643919 into konveyor:main Jun 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants