-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support running multi-language apps #259
Conversation
} | ||
|
||
func (a *analyzeCommand) setProviders(components []model.Component, foundProviders []string) ([]string, error) { | ||
if len(a.provider) > 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont think I completely understood this part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding provider(s) from --provider to the map instead of allowing language discovery to add them
ed007e3
to
165c440
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve when it's not in draft. One comment to help make rebase easier.
d0f9f73
to
258d0d3
Compare
Signed-off-by: Emily McMullan <[email protected]>
258d0d3
to
ea31e0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comments, otherwise good to merge
Signed-off-by: Emily McMullan <[email protected]>
ea31e0f
to
64bd9fd
Compare
--provider
string array flag, which can be used to bypass the default logic to explicitly set which provider(s) to run.--list-providers
flag to list supported providers.--overrideProvider
option, as it still must be a supported provider.In draft for more testing
Closes #245
Closes #248
Closes #260