-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Humble ignition gazebo #117
Conversation
blocked by ros-controls/gz_ros2_control#182 |
@@ -42,15 +42,52 @@ def node_spawn_entity( | |||
"robot_description", | |||
"-entity", | |||
LaunchConfiguration("robot_name"), | |||
"-robot_namespace", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verify this functions
interactive marker nonreactive for moveit launches |
read up on migration guide: https://gazebosim.org/docs/harmonic/migrating_gazebo_classic_ros2_packages |
I tried to run this locally, and there is a dependency problem with the fri_vendor package. |
hi @jclinton830 and thank you for the feedback. This PR was left a little behind, hence why it likely doesn't work. |
@mhubii Any idea on when this will be merged into the humble branch? Happy to assist with the process if it expedites it. |
hi @jclinton830 and sorry for the late response. Happy to review your PR if you decide to contribute! Best way to do this is to start from the
You can get inspiration:
|
Hi @mhubii I have forked your humble version and have made my own branch called dev-humble-ign. https://github.com/acfr/lbr_fri_ros2_stack/tree/dev-humble-ign Do you take PRs directly into humble from forks? |
sorry for the late response @jclinton830. This branch should now work. One remaining issue: Somehow the new Gazebo seems slow. The
and accessed from:
has an integrator step size ( <physics name="1ms" type="ignored">
<max_step_size>0.001</max_step_size> If you set this from One might need to add an You can target PRs against this branch ( |
What is the average real-time factor you are witnessing? In the above branch that I made in my forked version gazebo is working fast, with an average real-time factor of 90%. Also, have you fixed the problem of not being able to move the robot using the interactive marker? |
With integrator step size
Yes that's working now. You can e.g. try: ros2 launch lbr_bringup gazebo.launch.py \
model:=med7 and ros2 launch lbr_bringup move_group.launch.py \
rviz:=true \
mode:=gazebo \
model:=med7 If you could add a way to load a custom Note you can do this even after this PR gets merged. |
Ignition Gazebo
Ignition Gazebo (Gazebo) will be the predecessor of Gazebo (Gazebo Classic). This PR aims to already support Ignition Gazebo.
Currently, most functionality in this PR works, except for the interactive marker for MoveIt 2. For early adoption, this repo can be checked out
dev-humble-ignition-gazebo
. It can be run as usual.iiwa7.webm
Tasks
ros-humble-ros-gz
ros-humble-gazebo-ros