feat(ingest): Use NCBI API key, and don't retry, to not exceed request limits #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
corneliusroemer
commented
May 10, 2024
•
corneliusroemer
commented
- Don't retry when NCBI ingest fails, as this causes rate limits to trip
- Use NCBI API Key. In cleartext for now (while we're private that's no problem). It's easy to generate these keys and easy to reset so there's no risk to using it like this right now. For proper encryption see Set NCBI API key through secret #1844
corneliusroemer
requested review from
theosanderson,
chaoran-chen and
anna-parker
chaoran-chen
approved these changes
May 10, 2024
corneliusroemer
added a commit
that referenced
this pull request
May 10, 2024
…t limits (#1845) -Don't retry when NCBI ingest fails, as this causes rate limits to trip -Use NCBI API Key. In cleartext for now (while we're private that's no problem). It's easy to generate these keys and easy to reset so there's no risk to using it like this right now. For proper encryption see Set NCBI API key through secret #1844 (cherry picked from commit 1dbfcba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.