fix(deployment): allow backend, and hopefully loculus, to be used with no "genes" specified, only a genome #2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theosanderson
force-pushed
the
no-genes
branch
from
7fdc9b9
to
5e19096
Compare
theosanderson
commented
Aug 22, 2024
theosanderson
commented
Aug 22, 2024
theosanderson
changed the title
anna-parker
approved these changes
Aug 22, 2024
2 tasks
theosanderson
force-pushed
the
no-genes
branch
from
5e19096
to
73e3604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #787
Allows Loculus to be used with a reference-only, no genes. This was always intended behaviour but we had a bug in the deployment which meant that when no genes were configured in the values file, the backend config JSON ended up with
genes: nullnotgenes : []. That is now fixed. There may be other teething issues to identify downstream (though I'm hopeful there are not) but we can fix those as we find them.