feat: support filtering for warnings only on the review page #3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhennig
force-pushed
the
feat/3031-improve-review-page
branch
from
8bd7c88 to
7e9ea3a
Compare
backend/src/main/kotlin/org/loculus/backend/api/SubmissionTypes.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/controller/SubmissionController.kt
Outdated
Show resolved
Hide resolved
…/SequenceEntriesView.kt Co-authored-by: Chaoran Chen <[email protected]>
|
I fixed the pagination bit in this commit: cddfe83 Ideally the number of results would maybe be returned in the |
chaoran-chen
approved these changes
Nov 12, 2024
| @@ -7,28 +7,26 @@ | |||
| } | |||
| state REVISION_DATA as "revision data" #aliceblue;line:blue;line.dotted;text:blue { | |||
| REVISION_DATA: already existing sequence | |||
| REVISION_DATA: with status APPROVED_FOR_RELEASE | |||
| REVISION_DATA: with status RELEASED | |||
There was a problem hiding this comment.
This should probably still be APPROVED_FOR_RELEASE - I agree it would be nice to rename to RELEASED but afaict this hasn't happened yet in the code base.
|
I wonder if this change should be reverted: #3125 (comment) until we have made it in code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #3031
fixes #2566
fixes #1447
fixes #3198 -- ac6aa79
preview URL: https://feat-3031-improve-review.loculus.org/
Summary
This PR merges the HAS_ERRORS and AWAITING_APPROVAL statuses in the SequenceEntryView. Instead errors are handled by looking at the errors column. The
get-sequencesendpoint now supports filtering by processing result (no_issues,warnings,errors) and also returns the counts for these states.The UI has been adapted to support filtering.
Documentation has been updated.
The PR also adds confirmation dialogs to individual sequence publishing or deletion (#2566)
Screenshot
PR Checklist