Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code result error for set and update syntax for some set/map page #29586

Closed
wants to merge 1 commit into from

Conversation

JasonLamv-t
Copy link
Member

@JasonLamv-t JasonLamv-t commented Oct 11, 2023

Description

  1. Fix code result error in set.@@iterator and improve another code example in set.clear, according to preview comments in [zh-cn]: update the translation of Set constructor&@@iterator()&@@species translated-content#16466 (comment) and [zh-cn]: update the translation of Set.add()&clear()&delete()&has() translated-content#16479 (comment).
  2. Update the syntax part of the pages of set&map 's instance methods, to unify @Josh-Cena's recent changes which clear these methods are instances' methods.

Motivation

Ditto.

Additional details

Related issues and pull requests

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! This is not how syntax boxes work. We don't add the prefix unless the method's name is a keyword, because with() is not a function call. This is not a problem with the methods here.

@Josh-Cena Josh-Cena closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants