Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn]: update the translation of Set constructor&@@iterator()&@@species #16466

Merged
merged 6 commits into from
Oct 24, 2023
Merged

[zh-cn]: update the translation of Set constructor&@@iterator()&@@species #16466

merged 6 commits into from
Oct 24, 2023

Conversation

JasonLamv-t
Copy link
Member

Description

Same as the title.

Motivation

Ditto.

Additional details

None.

Related issues and pull requests

#16465

@JasonLamv-t JasonLamv-t requested a review from a team as a code owner October 9, 2023 03:33
@JasonLamv-t JasonLamv-t requested review from irvin and removed request for a team October 9, 2023 03:33
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Oct 9, 2023
@JasonLamv-t JasonLamv-t mentioned this pull request Oct 9, 2023
Closed
13 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023 •
edited
Loading

Preview URLs

Flaws (2)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /zh-CN/docs/Web/JavaScript/Reference/Global_Objects/Set/@@iterator
Title: Set.prototype[@@iterator]()
Flaw count: 2

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
External URLs (1)

URL: /zh-CN/docs/Web/JavaScript/Reference/Global_Objects/Set/Set
Title: Set() 构造函数

(comment last updated: 2023-10-24 02:55:30)

JasonLamv-t
JasonLamv-t commented Oct 10, 2023
View reviewed changes
Copy link
Member Author

@JasonLamv-t JasonLamv-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translate 「set」 to 「集合」

files/zh-cn/web/javascript/reference/global_objects/set/@@iterator/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/javascript/reference/global_objects/set/@@iterator/index.md Outdated Show resolved Hide resolved
yin1999
yin1999 reviewed Oct 10, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

files/zh-cn/web/javascript/reference/global_objects/set/@@iterator/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/javascript/reference/global_objects/set/@@iterator/index.md Outdated Show resolved Hide resolved
@JasonLamv-t JasonLamv-t mentioned this pull request Oct 11, 2023
Closed
@JasonLamv-t JasonLamv-t mentioned this pull request Oct 23, 2023
Merged
@JasonLamv-t JasonLamv-t requested a review from yin1999 October 24, 2023 02:53
yin1999
yin1999 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @JasonLamv-t

@yin1999 yin1999 changed the title [zh-cn]: update translation of Set.constructor&@@iterator()&@@species [zh-cn]: update the translation of Set constructor&@@iterator()&@@species Oct 24, 2023
@yin1999 yin1999 merged commit 8496dab into mdn:main Oct 24, 2023
@JasonLamv-t JasonLamv-t deleted the set-@@ branch October 24, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

@irvin irvin Awaiting requested review from irvin irvin is a code owner automatically assigned from mdn/yari-content-zh

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonLamv-t @yin1999