ko: Convert noteblocks to GFM Alerts (part 1) #22758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR converts the noteblocks for the Korean locale to GFM Alerts syntax, using a [conversion script](https://github.com/queengooborg/mdn-toolkit/blob/main/upgrade-noteblock.js). This is part 1. Note: manual adjustments have also been made to correct some issues, including capitalization, syntax, duplicated keywords and more.
Preview URLs (100 pages)
Flaws (7127)Note! 16 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
No first query argument or 'browser-compat' or 'spec-urls' front-matter value passed`
No first query argument or 'browser-compat' front-matter value passed`
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
External URLs (69)URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
(comment last updated: 2024-08-08 08:19:52) |
|
@queengooborg Hello. Contributors are slow to respond to existing PRs(and there is too much PR. We want to merge as much as possible.), so we plan to merge them first and then merge the current noteblocks-related PRs after requesting a batch resolution on Wednesday. I kindly ask for your understanding. |
|
I can totally understand wanting to work through the existing backlog first before performing this conversion! There's no rush to merge this right away -- it isn't a blocker on any Yari updates or other things, and is mainly for convenience purposes. I'll keep these PRs open for when you/the Korean team is ready to review and merge them, and naturally, will fix any merge conflicts along the way! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the noteblocks for the Korean locale to GFM Alerts syntax, using a conversion script. This is part 1. Note: manual adjustments have also been made to correct some issues, including capitalization, syntax, duplicated keywords and more.