-
Notifications
You must be signed in to change notification settings - Fork 29
Update taxon filter to remove 'facets' filter #168
Comments
Somewhat related to monarch-initiative/monarch-app#789 - @jmcmurry perhaps we should consider punting monarch-initiative/monarch-app#789 to the Monarch-UI v1.1 milestone in favour of this ticker, for now. |
There are only a few card types that "have taxon". Previously.. we were building facets based off the total card counts and when selecting/deselecting a taxon, it would update the counts. When moving to a table level taxon we need the counts per taxon based on the card type.. For example homolog or genotype. But since we are paginating I only have unique taxon counts for that page. |
Ping to @deepakunni3 as well. |
If you set facet=true when getting the data it should return some meaningful facets, but it looks like it's hard coded for subject_taxon_label and object_closure. It would be useful to make this configurable at the API level similar to solr, ie a facet_field param. |
We need some @deepakunni3 awesomeness. right.here. Haaaalp! 🙏 |
So, I've almost fully implemented this, there seems to be a few endpoints under gene that don't support "taxon" by array. When that is cleared I think this ticket is finished. /gene/{id}/homologs |
@deepakunni3 looks like variants endpoint is still not filtering correctly in dev, homologs looks good |
@iimpulse Could you provide an example gene where you are seeing this? Just for sake of testing and debugging |
@iimpulse This should be now fixed on api-dev |
Work also being done at monarch-initiative/dipper#860 |
Updates on how to proceed? @monicacecilia |
I've added some code to biolink to query taxa directly, which should fix the odd filter behavior. However, we're having network issues on our servers and I can't stage the changes on api-dev. Essentially it will be adding a new param, direct_taxon=true, when loading the tables. If you want to get your PR ready I can just update it when the api is ready. |
@iimpulse to filter on a taxon/taxa directly, add direct_taxon: true to the params, for example |
FOR NOW, a decision has been made to remove the current 'facets' filters shown on the left column of our results pages and instead:
Don't @ me.
The text was updated successfully, but these errors were encountered: