Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

Update taxon filter to remove 'facets' filter #168

Closed
2 tasks done
monicacecilia opened this issue Aug 8, 2019 · 14 comments
Closed
2 tasks done

Update taxon filter to remove 'facets' filter #168

monicacecilia opened this issue Aug 8, 2019 · 14 comments
Assignees
Labels

Comments

@monicacecilia
Copy link
Contributor

monicacecilia commented Aug 8, 2019

FOR NOW, a decision has been made to remove the current 'facets' filters shown on the left column of our results pages and instead:

  • create a taxon filter on the right side of the results pages (a table filter)
  • add this filter ONLY to pages with gene results

Don't @ me. :bowtie:

@monicacecilia
Copy link
Contributor Author

Somewhat related to monarch-initiative/monarch-app#789 - @jmcmurry perhaps we should consider punting monarch-initiative/monarch-app#789 to the Monarch-UI v1.1 milestone in favour of this ticker, for now.

@iimpulse
Copy link
Member

@kshefchek @monicacecilia

There are only a few card types that "have taxon". Previously.. we were building facets based off the total card counts and when selecting/deselecting a taxon, it would update the counts. When moving to a table level taxon we need the counts per taxon based on the card type..

For example homolog or genotype. But since we are paginating I only have unique taxon counts for that page.

@monicacecilia
Copy link
Contributor Author

Ping to @deepakunni3 as well.

@kshefchek
Copy link
Contributor

If you set facet=true when getting the data it should return some meaningful facets, but it looks like it's hard coded for subject_taxon_label and object_closure. It would be useful to make this configurable at the API level similar to solr, ie a facet_field param.

@monicacecilia
Copy link
Contributor Author

We need some @deepakunni3 awesomeness. right.here. Haaaalp! 🙏

@monicacecilia monicacecilia added the blocked Something needs to be done before work can proceed label Sep 13, 2019
@iimpulse
Copy link
Member

iimpulse commented Sep 13, 2019

So, I've almost fully implemented this, there seems to be a few endpoints under gene that don't support "taxon" by array. When that is cleared I think this ticket is finished.

/gene/{id}/homologs
/gene/{id}/variants

@deepakunni3 @kshefchek

@iimpulse
Copy link
Member

iimpulse commented Oct 24, 2019

@deepakunni3 looks like variants endpoint is still not filtering correctly in dev, homologs looks good

@deepakunni3
Copy link
Collaborator

@iimpulse Could you provide an example gene where you are seeing this? Just for sake of testing and debugging

@deepakunni3
Copy link
Collaborator

@iimpulse This should be now fixed on api-dev

@monicacecilia
Copy link
Contributor Author

Work also being done at monarch-initiative/dipper#860

@iimpulse
Copy link
Member

iimpulse commented Nov 22, 2019

Updates on how to proceed? @monicacecilia

@kshefchek
Copy link
Contributor

I've added some code to biolink to query taxa directly, which should fix the odd filter behavior. However, we're having network issues on our servers and I can't stage the changes on api-dev. Essentially it will be adding a new param, direct_taxon=true, when loading the tables. If you want to get your PR ready I can just update it when the api is ready.

@iimpulse iimpulse removed blocked Something needs to be done before work can proceed blocked by API labels Jan 24, 2020
@kshefchek
Copy link
Contributor

@iimpulse to filter on a taxon/taxa directly, add direct_taxon: true to the params, for example
https://api.monarchinitiative.org/api/bioentity/gene/HGNC%3A10896/variants?rows=100&direct_taxon=true&taxon=NCBITaxon:9606

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants