DO NOT MERGE: Bug fix: Synonym Sync: Entries without exact mappings - mini build #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeflack4
force-pushed
the
bugfix-syn-sync-no-exact-mappings-1-base-outputs
branch
from
aab2d9e
to
72f1862
Compare
joeflack4
force-pushed
the
bugfix-syn-sync-no-exact-mappings-3-new-outputs
branch
2 times, most recently
from
1087883
to
ca0a63f
Compare
9 tasks
joeflack4
changed the title
joeflack4
added
the
build
joeflack4
commented
Nov 20, 2024
| @@ -2316,7 +2283,6 @@ MONDO:0002508 gingivitis oio:hasExactSynonym gingivitis DOID:3087 gingivitis | |||
| MONDO:0002512 papillary adenocarcinoma oio:hasExactSynonym papillary adenocarcinoma DOID:3112 papillary adenocarcinoma papillary adenocarcinoma DOID:3112 | |||
| MONDO:0002513 kidney benign neoplasm oio:hasExactSynonym kidney benign neoplasm DOID:3116 kidney benign neoplasm kidney benign neoplasm DOID:3116 | |||
| MONDO:0002513 kidney benign neoplasm oio:hasExactSynonym renal and ureteral tumor DOID:3116 kidney benign neoplasm renal and ureteral tumor DOID:3116 | |||
| MONDO:0002514 hepatobiliary neoplasm oio:hasExactSynonym hepatobiliary tumors DOID:3117 hepatobiliary benign neoplasm hepatobiliary tumors DOID:3117 | |||
There was a problem hiding this comment.
Case 1 of 2 removed
As shown in the QC error in #687, this pair (MONDO:0002514, DOID:3117) had no exact mapping. Now it is removed.
joeflack4
commented
Nov 20, 2024
joeflack4
force-pushed
the
bugfix-syn-sync-no-exact-mappings-1-base-outputs
branch
from
72f1862
to
0774062
Compare
- Add: Outputs to compare to before the code in order to check the diffs for correctness.
joeflack4
force-pushed
the
bugfix-syn-sync-no-exact-mappings-3-new-outputs
branch
from
ca0a63f
to
ff45d10
Compare
|
Closing this as now redundant with: |
joeflack4
deleted the
bugfix-syn-sync-no-exact-mappings-3-new-outputs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mini-build for:
Compares just the synonym sync outputs, before and after the code changes.
Full build also exists: