Subclass Sync - Direct in source, indirect in Mondo #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeflack4
force-pushed
the
subclass-sync-direct-source-indirect-mondo
branch
from
66141ce
to
7a1411b
Compare
- Update: Added Python code to implement this case - Update: Includes some refactoring around common '-confirmed' cases and in general
joeflack4
force-pushed
the
subclass-sync-direct-source-indirect-mondo
branch
from
7a1411b
to
2055a00
Compare
- Update: Formalized new output *confirmed-direct-source-indirect-mondo.robot.tsv
joeflack4
force-pushed
the
subclass-sync-direct-source-indirect-mondo
branch
from
4d366d4
to
cf5cf23
Compare
- Needed to fix an inconsistent named param - Added some previously missing make prereqs - Removed a todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #708
Overview
Added code to implement Subclass Sync "case 2": Direct in source, indirect in Mondo.
Pre-merge checklist
Documentation
Was the documentation added/updated under
docs/?QC
Was the full pipeline run before submitting this PR using
sh run.sh make build-mondo-ingeston this branch (afterdocker pull obolibrary/odkfull:dev), and no errors occurred?Mini build:
New Packages
Were any new Python packages added?
Were any other non-Python packages added?
PR Review and Conversations Resolved
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?
Additional info
I ran output and observed that the case in #708 appeared as expected!:
See: Google Sheets:
sync-subClassOf.confirmed-direct-source-indirect-mondo.tsv