-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use extern functions in dispatch table #90
feat: use extern functions in dispatch table #90
Conversation
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
=========================================
- Coverage 74.63% 74.33% -0.3%
=========================================
Files 117 119 +2
Lines 8893 9199 +306
=========================================
+ Hits 6637 6838 +201
- Misses 2256 2361 +105
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! A very clean and minimal implementation.
It might be good to add unit tests for all of the different types that can be input as intrinsic arguments and return types.
This adds dynamic linking of
malloc
through the dispatch table. The use of malloc is still hacked in the runtime but this allows us to integrate all PRs that require it.