Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show error when signing in with unregistered email #299

Merged
merged 5 commits into from
Dec 22, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/polite-monkeys-travel.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"namesake": minor
---

fix: Show error when signing in with unregistered email
nakul-py marked this conversation as resolved.
Show resolved Hide resolved
75 changes: 59 additions & 16 deletions src/routes/_unauthenticated/signin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,39 +30,82 @@ export const Route = createFileRoute("/_unauthenticated/signin")({
});

const SignIn = () => {
const { signIn } = useAuthActions();
const { signIn} = useAuthActions();
nakul-py marked this conversation as resolved.
Show resolved Hide resolved
const [flow, setFlow] = useState<Key>("signIn");
const [email, setEmail] = useState<string>("");
const [password, setPassword] = useState<string>("");
const [isSubmitting, setIsSubmitting] = useState(false);
const [error, setError] = useState<string | null>(null);
const [error, setError] = useState<string | React.ReactNode | null>(null);
nakul-py marked this conversation as resolved.
Show resolved Hide resolved
const navigate = useNavigate({ from: "/signin" });
const isClosed = process.env.NODE_ENV === "production";

const checkUserExists = async (email: string): Promise<boolean> => {
try {
const response = await convex.query('checkUserExists', { email });

return response.exists;
} catch (err) {
if (err instanceof ConvexError && err.message === 'User does not exist') {
return false;
}
console.error(err);
return false;
}
};
nakul-py marked this conversation as resolved.
Show resolved Hide resolved

const handleSubmit = async (event: React.FormEvent<HTMLFormElement>) => {
event.preventDefault();
setIsSubmitting(true);
setError(null);

await signIn("password", {
flow,
email,
password,
redirectTo: "/quests",
})
.catch((error) =>
error instanceof ConvexError
? setError(error.message)
: setError(error),
)
.then(() => navigate({ to: "/" }))
.finally(() => setIsSubmitting(false));
try {
if (flow === "signIn") {
const userExists = await checkUserExists(email);
if (!userExists) {
setError(
<>
There isn't an account for this email. Would you like to{" "}
<button
type="button"
onClick={() => setFlow("signUp")}
style={{
color: "blue",
textDecoration: "underline",
background: "none",
border: "none",
padding: 0,
cursor: "pointer",
}}
>
register a new account
</button>
?
</>
);
setIsSubmitting(false);
return;
}
}

await signIn("password", {
flow,
email,
password,
redirectTo: "/quests",
});
navigate({ to: "/" });
} catch (err) {
setError('An unexpected error occurred. Please try again.');
setIsSubmitting(false);
console.error(err);
}
};

if (flow === "reset")
if (flow === "reset") {
return (
<ForgotPassword onBack={() => setFlow("signIn")} defaultEmail={email} />
);
}

return (
<Tabs selectedKey={flow} onSelectionChange={setFlow}>
Expand Down
Loading