Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Spack target architecture - Wave #391

Closed
wants to merge 3 commits into from

Conversation

marcodelapierre
Copy link
Contributor

@marcodelapierre marcodelapierre commented Jan 31, 2024

This PR reinstates support for the spackTarget attribute within Wave.

It comes in conjunction with this Nextflow PR: nextflow-io/nextflow#4701 , and a corresponding Libseqera PR: seqeralabs/libseqera#11.

Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
@marcodelapierre
Copy link
Contributor Author

marcodelapierre commented Jan 31, 2024

@pditommaso CI failure is upstream at the build stage: requires Libseqera PR seqeralabs/libseqera#11.

Locally:

  • the build succeeds;
  • the test failures are all unrelated to this PR, but rather to authentication issues (Docker and so on), which would not happen here in the repo.

I suggest to first merge the Libseqera one, then come back here.

@marcodelapierre marcodelapierre self-assigned this Jan 31, 2024
Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]>
@pditommaso
Copy link
Collaborator

Closing as Spack support will not be maintained anymore

@pditommaso pditommaso closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants