-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fairmat 2024: use NXcoordinate_system together with NXtransformations #1415
base: main
Are you sure you want to change the base?
Fairmat 2024: use NXcoordinate_system together with NXtransformations #1415
Conversation
d5b73b5
to
677b6a1
Compare
52e7bac
to
7f010d8
Compare
* Updates NXtransformations docs * Manually set to lower case true * Do a forward-backward nyaml cycle for NXtransformations # Conflicts: # base_classes/nyaml/NXtransformations.yaml
# Conflicts: # base_classes/nyaml/NXtransformations.yaml
# Conflicts: # base_classes/nyaml/NXtransformations.yaml
# Conflicts: # base_classes/NXtransformations.nxdl.xml # base_classes/nyaml/NXtransformations.yaml
Copying here discussion that was buried in #1464 for clarity: LP: we shall align to and extend the existing ISO standard for XPS. The concept of coordinate systems allow connecting multiple conventions. |
This PR is concerned with coordinate systems and the transformations that are intricately linked to them. It was started for multiple reasons:
NXxps
) one could explicitly state which coordinate system is to be used. There has already been some discussion on this, see NXmpes #1464 (comment)NXtransformations
) does already allow to define a specific coordinate system (see e.g. discussion in NXtransformations: clarify that these are active transformations + example #1278). But, this has several limitations:Therefore, we introduce in this PR two new base classes:
NXcoordinate_system
andNXcoordinate_system_set
.Explanation of using
NXcoordinate_system
andNXtransformation
:NX_coordinate_system_set
contains one or more ofNXcoordinate_system
NXcoordinate_system
, there is adepends_on
, and(NXtransformation)
groupNXtransformation
AXISNAME
depends_on
, one can place either"."
, or the path to anNX_coordinate_system
depends_on
attribute or field links to aNXcoordinate_system
, it should pick the respectivedepends_on
field in that class, and apply the specifiedTRANSFORMATIONS
Example of how this is implemented in a (proposed) application definition: NXXps