init: atomic-browser at 0.37.0 #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No difference in |
1 similar comment
|
No difference in |
albertchae
force-pushed
the
moss/atomix-browser-pnpm-nzbr
branch
from
13fa66c
to
4b6f3e2
Compare
|
No difference in |
albertchae
commented
Mar 6, 2024
There was a problem hiding this comment.
Tried to make this file follow the format of all the others since it appears they were standardized at some point
albertchae
added a commit
to ngi-nix/atomic-server
that referenced
this pull request
Mar 6, 2024
…uses one typescript version (5.3.2) We came across this while working on ngi-nix/ngipkgs#164. While not strictly necessary for that task, it seemed like it was unintentional that the project was depending on different versions of typescript (PR with original upgrade is atomicdata-dev#710), so I removed typescript in the various subdirectories so they all depend on the same version as root. - Edit tsconfig.build.json to fix the following error `TS5110: Option 'module' must be set to 'NodeNext' when option 'moduleResolution' is set to 'NodeNext'.` - All the removed packages from pnpm-lock.yaml are duplicate entries
Chickensoupwithrice
approved these changes
Mar 7, 2024
- Use pnpm2nix-nzbr which supports pnpm version 6 lockfiles. - Because atomic-browser is using pnpm workspaces, `installInPlace` and `distDir="."` A follow up PR will create a module for this Co-authored-by: Anish Lakhwara <[email protected]>
albertchae
force-pushed
the
moss/atomix-browser-pnpm-nzbr
branch
from
4b6f3e2
to
2015a5d
Compare
|
No difference in |
|
This is failing CI because the builder we introduced (https://github.com/nzbr/pnpm2nix-nzbr/) is using IFD. We are exploring alternatives |
|
Discussed with @albertchae and @Chickensoupwithrice Closing in favor of #170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next step of #15
installInPlaceanddistDir="."A follow up PR will create a module for this
Co-authored-by: Anish Lakhwara [email protected]