WIP Add Fastboot testing (official support) #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickschot
force-pushed
the
fix-fastboot
branch
from
7ef3c74
to
65cd31f
Compare
nickschot
force-pushed
the
fix-fastboot
branch
from
65cd31f
to
5b253ee
Compare
nickschot
force-pushed
the
fix-fastboot
branch
from
5b253ee
to
f360a28
Compare
nickschot
changed the title
This was referenced Feb 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup for #891
This adds actual fastboot testing. Currenty blocked on fastboot not supporting embroider optimized due to:
https://github.com/ember-fastboot/ember-cli-fastboot/blob/master/packages/ember-cli-fastboot/vendor/experimental-render-mode-rehydrate.js which is app.imported here https://github.com/ember-fastboot/ember-cli-fastboot/blob/master/packages/ember-cli-fastboot/index.js#L75