Inline body scroll lock library, apply small fixes & (unofficial) fastboot support #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickschot
force-pushed
the
inline-body-scroll-lock
branch
from
77beee2
to
67bfdb3
Compare
Merged
This was referenced Feb 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/willmcpo/body-scroll-lock has been unmaintained for a couple of years now. There's some small bugs in there and it's breaking fastboot too. Inlining it allows us to fix these issues in a straightforward way. The library is pretty small, so this should be fine.
This (unofficially) also re-adds fastboot support since we can now modify this library in a way to make it work. Fastboot is currently incompatible with embroider optimized, so we can't add tests for it yet. This will be added later through #854 .