Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nyc doesn't support ESM, but c8 does!
I'm not building this by default on test:mocha because it slows things down quite a bit (down to 32s from 24s) ((and tests are already too slow)).
So you need to run
yarn test:coverage
to run this. It outputs the following text report (in color):It also outputs coverage/lcov.info which we can use for example with the coverage-gutters extension in VSCode.
I was pleasantly surprised by our current coverage. Many of the missing lines are the ones that throw an error on invalid options.
Some thoughts/questions:
do we need c8 as a dev dependency (I could use npx instead)