Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Execute tests even if QA checks fail, build anyway #136

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

nemesifier
Copy link
Member

Let's not stop testing if QA checks fail.
Let's build in any case to make sure build errors are spotted also if tests fail.
If a PR from a new contributor doesn't look good we can avoid running the build entirely.

@nemesifier nemesifier added the enhancement New feature or request label Jul 4, 2024
@nemesifier nemesifier self-assigned this Jul 4, 2024
@coveralls
Copy link

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9799783843

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.689%

Totals Coverage Status
Change from base Build 9274835172: 0.0%
Covered Lines: 3207
Relevant Lines: 3217

💛 - Coveralls

@nemesifier nemesifier merged commit 9a2d810 into master Jul 4, 2024
2 checks passed
@nemesifier nemesifier deleted the update-ci branch July 4, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants