Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub area models #91

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Sub area models #91

wants to merge 10 commits into from

Conversation

chantelwetzel-noaa
Copy link
Contributor

Added new functionality to add identifier text to the reference label and tex file name for tables. This allows users to reference and include the same table from other model areas. As example, copper rockfish in CA is being modeled as two separate areas within the state. Adding "north" or "south" text to the beginning of a table label which allows each table to be referenced as unique tables in the text.

Chantel Wetzel added 2 commits April 5, 2023 10:53
The feature supports the ability to create an executive summary where you are describing two or more sub-area models.  The 'add_prefix' function input adds any text specified here that will be added the the tex file name and the table label for referencing in the document. Example two sub-area model where one is "north" and other is "south" model using 'add_prefix' will create a file called north_a_Catches_ES.tex with a unique label of north-catchesES.
Added function input for users to add a model identifier prefix that is passed to the es_table_tex function that will add the identified to the tex file names and the table labels.
@kellijohnson-NOAA
Copy link
Contributor

@chantelwetzel-noaa thanks for opening a pull request. I am just starting to look through this now and I am wondering if you can email me or provide a link to a pdf that uses this? I am struggling to see what the end out come is. Even a screen shot would work.

@chantelwetzel-noaa
Copy link
Contributor Author

I don't have a fully flushed out example to share but here is a line where I test to make sure each table has it own unique numbering. I don't have the pdf built currently because I just broke it moving to a different model.

The two copper rockfish assessments this cycle will need to have a executive summary section that describes the results of both models (see Black Rockfish 2015 or China Rockfish 2017 document for example). Currently, the r4ss::SSexecutivesummary function creates csv files and with a fixed naming system and then the helper functions sa4ss:read_model and sa4ss::ex_table_tex creates tex files with the same names and lables like a_Catches_ES.tex and \ref{tab:removalsES}. This creates issues when needing to add tables from two separate models. This pull request adds the functionality for a user to add a unique name before each of the tex files and labels (north_a_Catches_ES.tex and \ref{tab:north-removalsES}).

Chantel Wetzel added 3 commits April 21, 2023 13:35
The prefix function input was being incorrectly passed to the SS_output causing errors. This is a temporary workaround
@kellijohnson-NOAA kellijohnson-NOAA force-pushed the main branch 4 times, most recently from 676b352 to 8312132 Compare April 25, 2023 14:13
@kellijohnson-NOAA kellijohnson-NOAA force-pushed the main branch 6 times, most recently from 85cf12c to dde22a3 Compare May 17, 2023 22:47
Chantel Wetzel added 3 commits July 6, 2023 15:10
@kellijohnson-NOAA kellijohnson-NOAA force-pushed the main branch 2 times, most recently from 4a8d4ac to 865ba67 Compare July 11, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants