ENH: add sample_dict method to MultiFASTADirectoryFormat #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit edbd24a. This commit was moved to a separate branch/PR.
|
Hey @ebolyen, could we please merge this one? This change is required by https://github.com/bokulich-lab/q2-moshpit/pull/144/files, which was already merged... (my mistake, I missed that during the review) |
|
Just ran into this myself, looks good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #78 by adding the
sample_dictmethod to theMultiFASTADirectoryFormat, following how it was done for some other formats in:feature_dictmethod toMAGSequencesDirFmtbokulich-lab/q2-types-genomics#70.Additionally, closes #77.