MAINT: typo in feature_data_mag/__init__.py
#313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @lizgehret, could you maybe look this over? 🙏 |
You bet! Will take a look right now 🙂 |
lizgehret
approved these changes
May 1, 2024
There was a problem hiding this comment.
fixed some small merge conflicts- looks like we needed to update the imports for all three files (format, transformer, type) rather than just the transformer. thanks for catching this @Sann5! will just wait for ci to pass and then this will be good to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like all
__init__.pyfiles import the_transformer.pymodule from their corresponding submodule. Howeverfeature_data_mag/__init__.pyimports the transformer fromfeature_datanotfeature_data_mag. Is this a typo?