forked from marcelinomalmeidan/publishAirsimImgs
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Request - Point Cloud Publisher #2
Open
dehavenm
wants to merge
11
commits into
rakeshshrestha31:master
Choose a base branch
from
aravindk2604:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: airsim_iface.py - new AirSim-ROS interface node, intended to use PID loops to properly control the car in response to velocity commands published on ROS topic /cmd_vel_mux/input/teleop (change topic in line 259 when using node with robotic path planning) pid.py - PID loop code used by airsim_iface.py for throttle and steering control Instructions for installing dependencies and running have been updated for airsim_iface.py
Added function to convert depth image data from Airsim to XYZRGB point cloud ROS message, based on code from the following repos: https://github.com/Microsoft/AirSim/blob/master/PythonClient/multirotor/point_cloud.py https://github.com/spillai/pybot/blob/master/pybot/externals/ros/pointclouds.py Publisher is currently set to publish point cloud on topic front_center/point_cloud (line 322, airsim_interface.py)
new file: launch/laserscan.launch - launch file for built-in ROS node depthimage_to_laserscan.launch, converting depth image from AirSim virtual depth camera to laser scan data (emulating LIDAR unit) new file: launch/pointcloud.launch - launch file for built-in ROS nodelet point_cloud_xyzrgb, converting depth image into point cloud removed code from airsim_iface.py intended to generate point clouds Note: currently, both files appear to launch their respective nodes correctly, but neither is able to produce valid data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just updated my Python interface node with code for converting the depth image data from AirSim into ROS Pointcloud2 messages and publishing them. Could someone please look at it? Thank you.