Merges gitrepo and gitops controllers #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xavi0
force-pushed
the
2513-merge-gitrepo-gitopts
branch
2 times, most recently
from
5061a33 to
a9447f0
Compare
0xavi0
force-pushed
the
2513-merge-gitrepo-gitopts
branch
6 times, most recently
from
04f8436 to
08ff212
Compare
manno
changed the title
manno
reviewed
Jun 24, 2024
manno
reviewed
Jun 24, 2024
manno
reviewed
Jun 24, 2024
0xavi0
force-pushed
the
2513-merge-gitrepo-gitopts
branch
from
ec35369 to
3a1a210
Compare
Moves all the functionality implemented in the `gitrepo` controller to the `gitopts` controller. Signed-off-by: Xavi Garcia <[email protected]>
It also renames the `finalizerutils` to just `finalizer` and documents its functions Signed-off-by: Xavi Garcia <[email protected]>
0xavi0
force-pushed
the
2513-merge-gitrepo-gitopts
branch
from
3a1a210 to
dc4522c
Compare
Changes documentatin as suggested in code review. Signed-off-by: Xavi Garcia <[email protected]>
0xavi0
force-pushed
the
2513-merge-gitrepo-gitopts
branch
from
dc4522c to
a85ccff
Compare
manno
approved these changes
Jun 25, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all the functionality implemented in the
gitrepocontroller to thegitoptscontroller.Refers to: #2513