Filter entities in the UI (part 0): Make CustomContent more useful
#8645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct`, and has support for action button
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
abey79
changed the title
CustomContent more usefulCustomContent more useful
Wumpf
approved these changes
Jan 10, 2025
| } | ||
|
|
||
| impl ListItemContent for CustomContent<'_> { | ||
| fn ui(self: Box<Self>, ui: &mut egui::Ui, context: &ContentContext<'_>) { |
There was a problem hiding this comment.
having a bit of a deja vu - isn't this button handling code already somewhere else? (can't tell without digging if that's actually the case and whether that's even a concern)
There was a problem hiding this comment.
Yes, I already have some kind of abstraction for button thingies (could be menu, could be action). Look for the ItemButton trait. I'm using that in PropertyContent, so I'm piggy backing on it.
This was referenced Jan 13, 2025
This was referenced Jan 23, 2025
This was referenced Jan 31, 2025
abey79
added a commit
that referenced
this pull request
Feb 5, 2025
### Related - Closes #8903 - Part of #8586 - Part of a series of PR: - #8645 - #8652 - #8654 - #8672 - #8706 - #8728 - #8795 - #8863 - #8886 - #8933 ### What This PR supports `/` in filter query. Semantics are now as follows: - Queries are made of whitespace separated keyword. - Paths are not matched unless they match all keywords individually at least once. - Keywords may have 1 or more `/` separated "parts". - Single part keyword behave as before: paths are matched if they contain that keyword anywhere at least once. - Single part keyword can now be prefixed and/or postfixed with a slash, eg. "/fir". In that case, the keyword part must be found at the beginning and/or end of at least one path part to match (e.g. "/fir" matches "/my/first/entity" but doesn't match "xxfire/entity"). - Multi-part keyword (e.g. "a/b/c") match paths that contains corresponding, matching sequence of part (e.g. "/xxxxa/b/cxxxxx"). Such keywords can also be prefixed and/or postfixed with a "/", with the same semantics. <img width="293" alt="image" src="https://github.com/user-attachments/assets/efca95df-5021-425b-96d2-036aeb7d1236" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
CustomContentmore useful #8645re_blueprint_treeand add more tests #8795re_time_paneland add more tests #8863/in queries #8933What
This PR makes
CustomContentfor list items more useful, because I'll needed for the UI of the filter widget. I also cleans up a few things and updates the related snapshot test.