-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter entities in the UI (part 1): Introduce a filter widget #8652
Conversation
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
bc15274
to
e0fa976
Compare
e0fa976
to
96535ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
there seems to be some mixup between empty string and None matchers that needs to be cleaned up
Arf yeah I switched last minute to "" matching nothing instead of everything (upon Katya's suggestion during the demo), and clearly I didn't cleanup properly. |
96535ff
to
9a0a88e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
### Related - Closes #8903 - Part of #8586 - Part of a series of PR: - #8645 - #8652 - #8654 - #8672 - #8706 - #8728 - #8795 - #8863 - #8886 - #8933 ### What This PR supports `/` in filter query. Semantics are now as follows: - Queries are made of whitespace separated keyword. - Paths are not matched unless they match all keywords individually at least once. - Keywords may have 1 or more `/` separated "parts". - Single part keyword behave as before: paths are matched if they contain that keyword anywhere at least once. - Single part keyword can now be prefixed and/or postfixed with a slash, eg. "/fir". In that case, the keyword part must be found at the beginning and/or end of at least one path part to match (e.g. "/fir" matches "/my/first/entity" but doesn't match "xxfire/entity"). - Multi-part keyword (e.g. "a/b/c") match paths that contains corresponding, matching sequence of part (e.g. "/xxxxa/b/cxxxxx"). Such keywords can also be prefixed and/or postfixed with a "/", with the same semantics. <img width="293" alt="image" src="https://github.com/user-attachments/assets/efca95df-5021-425b-96d2-036aeb7d1236" />
Related
CustomContent
more useful #8645re_blueprint_tree
and add more tests #8795re_time_panel
and add more tests #8863/
in queries #8933What
This PR introduce a filter widget with the following feature:
FilterMatcher
, which is an helper object that performs the actual filteringNOTE: this will surely be entirely rewritten as we improve on the filter semantics