Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

target/riscv: single DMI accesses via batch #1100

Merged
merged 1 commit into from
Jul 18, 2024
Merged

target/riscv: single DMI accesses via batch #1100

merged 1 commit into from
Jul 18, 2024

Conversation

en-sc
Copy link
Collaborator

@en-sc en-sc commented Jul 3, 2024 •
edited
Loading

  • Eliminates the use of VLA, which is prohibited by doc/manual/style.txt:
    Link:

    riscv-openocd/doc/manual/style.txt

    Lines 164 to 166 in c6bb902

    - use malloc() to create dynamic arrays. Do @b not use @c alloca
    or variable length arrays on the stack. non-MMU hosts(uClinux) and
    pthreads require modest and predictable stack usage.

  • Unifies DMI access interface.

  • Reduces code duplication.

Requires: #1099, #1083

@en-sc en-sc self-assigned this Jul 4, 2024
@en-sc en-sc force-pushed the en-sc/single-as-batch branch from 15d3f8d to 1ee2a6d Compare July 4, 2024 09:24
@en-sc en-sc mentioned this pull request Jul 9, 2024
Merged
@en-sc en-sc force-pushed the en-sc/single-as-batch branch from 1ee2a6d to 3ea4b46 Compare July 9, 2024 12:12
MarekVCodasip
MarekVCodasip reviewed Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@MarekVCodasip MarekVCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. This is a big improvement.

I have a suggestion for you to consider, please take a look.

src/target/riscv/riscv-013.c Show resolved Hide resolved
JanMatCodasip
JanMatCodasip previously approved these changes Jul 10, 2024
View reviewed changes
@en-sc en-sc force-pushed the en-sc/single-as-batch branch from 3ea4b46 to 0a8668c Compare July 10, 2024 10:41
JanMatCodasip
JanMatCodasip previously approved these changes Jul 10, 2024
View reviewed changes
MarekVCodasip
MarekVCodasip previously approved these changes Jul 11, 2024
View reviewed changes
@en-sc en-sc dismissed stale reviews from MarekVCodasip and JanMatCodasip July 12, 2024 11:18

The merge-base changed after approval.

@en-sc
target/riscv: single DMI accesses via batch
9a489be 
* Eliminates the use of VLA, which is prohibited by `doc/manual
/style.txt`:
Link: https://github.com/riscv-collab/riscv-openocd/blob/c6bb902629924eb66aae2a08c0ab8654261c9d71/doc/manual/style.txt#L164-L166

* Unifies DMI access interface.

* Reduces code duplication.

Change-Id: I2d7b0595f171e21062049ff61f76fb5a3c992d11
Signed-off-by: Evgeniy Naydanov <[email protected]>
@en-sc en-sc force-pushed the en-sc/single-as-batch branch from 0a8668c to 9a489be Compare July 16, 2024 13:44
@en-sc en-sc merged commit 5afed58 into riscv-collab:riscv Jul 18, 2024
4 checks passed
@en-sc en-sc deleted the en-sc/single-as-batch branch July 18, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanMatCodasip JanMatCodasip JanMatCodasip approved these changes

@MarekVCodasip MarekVCodasip Awaiting requested review from MarekVCodasip

Assignees

@en-sc en-sc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@en-sc @JanMatCodasip @MarekVCodasip