Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target/riscv: fix memory access result type checker function return in case of assertion #1174

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

fk-sc
Copy link
Contributor

@fk-sc fk-sc commented Nov 22, 2024

No description provided.

@fk-sc fk-sc force-pushed the fk-sc/checker-fix branch from 212bb52 to 5046d22 Compare November 22, 2024 13:14
@TommyMurphyTM1234
Copy link
Collaborator

Wow! I assumed that "XXXX" was a placeholder for a particular expletive starting with 'F'. 😄

@fk-sc
Copy link
Contributor Author

fk-sc commented Nov 25, 2024

Wow! I assumed that "XXXX" was a placeholder for a particular expletive starting with 'F'. 😄

Oh... Maybe I should rename it to avoid ambiguity 😅

@aap-sc aap-sc requested a review from JanMatCodasip November 26, 2024 07:32
@aap-sc
Copy link
Collaborator

aap-sc commented Nov 26, 2024

LGTM (reviewed internally).

@JanMatCodasip would you kindly take a look?

@fk-sc fk-sc force-pushed the fk-sc/checker-fix branch from 5046d22 to b012ad6 Compare November 26, 2024 09:55
…n case of assertion

Fix memory access result type checker return in case of assertion

Signed-off-by: Farid Khaydari <[email protected]>
@fk-sc fk-sc force-pushed the fk-sc/checker-fix branch from b012ad6 to c8ae081 Compare November 26, 2024 09:57
@fk-sc fk-sc changed the title target/riscv: fix is_mem_access_XXXXed function return in case of assertion target/riscv: fix memory access result type checker function return in case of assertion Nov 26, 2024
Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@aap-sc aap-sc merged commit 0f0302b into riscv-collab:riscv Nov 28, 2024
4 checks passed
@fk-sc fk-sc deleted the fk-sc/checker-fix branch November 29, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants