Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target/riscv: fix memory access result type checker function return in case of assertion #1174

Merged
merged 1 commit into from
Nov 28, 2024
Merged

target/riscv: fix memory access result type checker function return in case of assertion #1174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/target/riscv/riscv-013.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3427,26 +3427,32 @@ bool is_mem_access_failed(mem_access_result_t status)
{
#define MEM_ACCESS_RESULT_HANDLER(name, kind, msg) \
case name: return kind == MEM_ACCESS_RESULT_TYPE_FAILED;

switch (status) {
LIST_OF_MEM_ACCESS_RESULTS
}

#undef MEM_ACCESS_RESULT_HANDLER

LOG_ERROR("Unknown memory access status: %d", status);
assert(false);
return false;
assert(false && "Unknown memory access status");
return true;
}

bool is_mem_access_skipped(mem_access_result_t status)
{
#define MEM_ACCESS_RESULT_HANDLER(name, kind, msg) \
case name: return kind == MEM_ACCESS_RESULT_TYPE_SKIPPED;

switch (status) {
LIST_OF_MEM_ACCESS_RESULTS
}

#undef MEM_ACCESS_RESULT_HANDLER

LOG_ERROR("Unknown memory access status: %d", status);
assert(false);
return false;
assert(false && "Unknown memory access status");
return true;
}

const char *mem_access_result_to_str(mem_access_result_t status)
Expand Down