target/riscv: Replace watchpoint value mask comparison value with macro. #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will rebase it once #954 gets merged |
This patch replaces ~(typeof(watchpoint->mask))0 with WATCHPOINT_IGNORE_DATA_VALUE_MASK. This improves readability and moves the RISCV target in line with other targets. Change-Id: I15ac4d4ee76098b304d9b22f720911ba4329c190 Signed-off-by: Marek Vrbka <[email protected]>
MarekVCodasip
force-pushed
the
use-watchpoint-mask-macro
branch
from
f1cfc4d to
2357237
Compare
|
@aap-sc Mentioned this change in #954. I have requested a review from @timsifive. |
JanMatCodasip
approved these changes
Nov 9, 2023
timsifive
approved these changes
Nov 9, 2023
en-sc
pushed a commit
to en-sc/riscv-openocd
that referenced
this pull request
Nov 10, 2023
…-mask-macro target/riscv: Replace watchpoint value mask comparison value with macro. Change-Id: I6767a2b9709b5dd13f96cc3fdb44052d75ceb585 Signed-off-by: Evgeniy Naydanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces ~(typeof(watchpoint->mask))0 with
WATCHPOINT_IGNORE_DATA_VALUE_MASK. This improves
readability and moves the RISCV target in line with
other targets.
Change-Id: I15ac4d4ee76098b304d9b22f720911ba4329c190
Signed-off-by: Marek Vrbka [email protected]