Add support for v5 keys/signatures. #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2111 +/- ##
==========================================
+ Coverage 76.97% 77.07% +0.10%
==========================================
Files 194 194
Lines 37074 37257 +183
==========================================
+ Hits 28536 28715 +179
- Misses 8538 8542 +4 ☔ View full report in Codecov by Sentry. |
ni4
force-pushed
the
ni4-821-basic-v5-keys-support
branch
from
e5f35c7 to
c1a099a
Compare
ni4
force-pushed
the
ni4-821-basic-v5-keys-support
branch
from
c1a099a to
6614927
Compare
| @@ -2573,19 +2583,22 @@ process_pgp_source(pgp_parse_handler_t *handler, pgp_source_t &src) | |||
| src_close(&datasrc); | |||
| } else { | |||
| if (handler->ctx->detached) { | |||
| RNP_LOG("Detached signature expected."); | |||
| RNP_LOG("Attached signature expected."); | |||
There was a problem hiding this comment.
-Detached
+Attached
is this correct?
There was a problem hiding this comment.
@antonsviridenko Yeah, some sort of double-check with typo from early times. Noticed when worked on surrounding code.
ni4
force-pushed
the
ni4-821-basic-v5-keys-support
branch
2 times, most recently
from
74460c6 to
7ff058e
Compare
ni4
force-pushed
the
ni4-821-basic-v5-keys-support
branch
from
7ff058e to
769dbff
Compare
ni4
force-pushed
the
ni4-821-basic-v5-keys-support
branch
from
769dbff to
e0d75cc
Compare
ni4
force-pushed
the
ni4-821-basic-v5-keys-support
branch
2 times, most recently
from
9957507 to
058888d
Compare
ni4
force-pushed
the
ni4-821-basic-v5-keys-support
branch
from
058888d to
5c3f339
Compare
antonsviridenko
approved these changes
Dec 10, 2023
ronaldtse
approved these changes
Dec 11, 2023
This was referenced Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet draft PR and now is intended to check added functionality via CI. MUST not be merged!
It includes:
What is going to be added: