Added LeadLag controller #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bmagyar
requested changes
Nov 30, 2017
| @@ -400,9 +400,6 @@ double Pid::getCurrentCmd() | |||
|
|
|||
| void Pid::getCurrentPIDErrors(double *pe, double *ie, double *de) | |||
| { | |||
| // Get the gain parameters from the realtime buffer | |||
| Gains gains = *gains_buffer_.readFromRT(); | |||
There was a problem hiding this comment.
I remember this frmo the previous PR. Reading the code suggests that really nothing happens here, right?
Could you please put this change into a different commit? It doesn't belong with the LeadLag stuff. Could still pass within the same PR as a minor fix.
| */ | ||
|
|
||
| #include <control_toolbox/lead_lag.h> | ||
| #include <tinyxml.h> |
There was a problem hiding this comment.
Do we really need tinyxml here? Could you check if the PID class also needs it? I had a look today and it didn't seem so...
There was a problem hiding this comment.
Yes, I don't really know if anyone uses it, but it is part of the public API for the PID class as well here
bool initXml(TiXmlElement *config);
|
Don't worry about the test that's failing now, it's due to our source-based test that lacks dependencies on Lunar. |
* Was not being used inside the scope of the method
progtologist
force-pushed
the
feature/LeadLagController
branch
from
25f0122 to
0a36c01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #60