-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Use reusable-reviewer-lottery from ros2_control_ci #1402
[CI] Use reusable-reviewer-lottery from ros2_control_ci #1402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
Logs here look good to me!
https://github.com/christophfroehlich/ros2_control/actions/runs/7942073051/job/21685010060?pr=2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1402 +/- ##
===========================================
+ Coverage 47.49% 75.88% +28.38%
===========================================
Files 41 41
Lines 3556 3359 -197
Branches 1938 1935 -3
===========================================
+ Hits 1689 2549 +860
+ Misses 459 419 -40
+ Partials 1408 391 -1017
Flags with carried forward coverage won't be shown. Click here to find out more. |
@christophfroehlich I've a question, does this job also take into account the github.actor conditions that we have currently? |
You mean this here? Afaik this is correctly used from the reusable workflow |
Yes that one! Awesome thanks |
(cherry picked from commit c4affe4)
(cherry picked from commit c4affe4)
This is a fix to #1395: The reviewer-lottery action only takes files from the local filesystem, which makes the action fail as reported here.
To fix this, I added a reusable workflow to ros2_control_ci using wget to download the config file.
I tested this here, this should work now.