Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of pre-commit hooks (backport #1073) #1074

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Bump version of pre-commit hooks (backport #1073) #1074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ repos:

# CPP hooks
- repo: https://github.com/pre-commit/mirrors-clang-format
rev: v17.0.6
rev: v18.1.0
hooks:
- id: clang-format
args: ['-fallback-style=none', '-i']
Expand Down
6 changes: 2 additions & 4 deletions joint_trajectory_controller/src/joint_trajectory_controller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,8 +477,7 @@ bool JointTrajectoryController::read_state_from_command_interfaces(JointTrajecto
auto interface_has_values = [](const auto & joint_interface)
{
return std::find_if(
joint_interface.begin(), joint_interface.end(),
[](const auto & interface)
joint_interface.begin(), joint_interface.end(), [](const auto & interface)
{ return std::isnan(interface.get().get_value()); }) == joint_interface.end();
};

Expand Down Expand Up @@ -548,8 +547,7 @@ bool JointTrajectoryController::read_commands_from_command_interfaces(
auto interface_has_values = [](const auto & joint_interface)
{
return std::find_if(
joint_interface.begin(), joint_interface.end(),
[](const auto & interface)
joint_interface.begin(), joint_interface.end(), [](const auto & interface)
{ return std::isnan(interface.get().get_value()); }) == joint_interface.end();
};

Expand Down
7 changes: 3 additions & 4 deletions joint_trajectory_controller/test/test_trajectory_controller_utils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,10 +244,9 @@ class TrajectoryControllerTest : public ::testing::Test
{
auto has_nonzero_vel_param =
std::find_if(
parameters.begin(), parameters.end(),
[](const rclcpp::Parameter & param) {
return param.get_name() == "allow_nonzero_velocity_at_trajectory_end";
}) != parameters.end();
parameters.begin(), parameters.end(), [](const rclcpp::Parameter & param)
{ return param.get_name() == "allow_nonzero_velocity_at_trajectory_end"; }) !=
parameters.end();

std::vector<rclcpp::Parameter> parameters_local = parameters;
if (!has_nonzero_vel_param)
Expand Down
Loading