-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pid_controller build on ROS 2 Rolling on Ubuntu 24.04 #1084
Fix pid_controller build on ROS 2 Rolling on Ubuntu 24.04 #1084
Conversation
Two things are needed to make this compile: 1. Make sure to add a package.xml dependency on backward_ros, which is necessary to compile. 2. Make sure to #include <rclcpp/version.h>, so the correct rclcpp::QoS object is chosen. With both of these in place, this package compiles cleanly on Ubuntu 24.04. Signed-off-by: Chris Lalancette <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes.
Regarding the backward_ros
dependency, I've just observed the missing dependency in the following packages as well: ackermann_steering_controller
, bicycle_steering_controller
, tricycle_steering_controller
. Can you also add them in the same PR?.
Thank you
Signed-off-by: Chris Lalancette <[email protected]>
Yes, very good call. Fixed now in 175c4d5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the changes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Rolling coverage CI seems to be failing here because the action is not installing It doesn't look to be connected with this PR, so I don't think it should hold this up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant, thank you!
A release into Rolling would be much appreciated, as it would close out this particular problem. Thanks! |
Two things are needed to make this compile:
With both of these in place, this package compiles cleanly on Ubuntu 24.04.
This should fix the CI build like in https://build.ros2.org/view/Rbin_uN64/job/Rbin_uN64__pid_controller__ubuntu_noble_amd64__binary/13/console
Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:
To send us a pull request, please:
colcon test
andpre-commit run
(requires you to install pre-commit bypip3 install pre-commit
)