Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JTC trajectory end time validation fix (backport #1090) #1141

Merged
merged 1 commit into from
May 22, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 22, 2024

The time_from_start member for a JointTrajectoryPoint is monotonically increasing, not a delta time, so I think we can just use the last one in the vector; summing them up seems incorrect. I also moved the points empty check earlier because .back().time_from_start would seg fault with an empty points vector.


This is an automatic backport of pull request #1090 done by Mergify.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.78%. Comparing base (12a2ef2) to head (fe85da4).

Additional details and impacted files
@@            Coverage Diff             @@
##             iron    #1141      +/-   ##
==========================================
+ Coverage   86.76%   86.78%   +0.01%     
==========================================
  Files          86       86              
  Lines        7397     7399       +2     
  Branches      614      612       -2     
==========================================
+ Hits         6418     6421       +3     
  Misses        749      749              
+ Partials      230      229       -1     
Flag Coverage Δ
unittests 86.78% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ory_controller/src/joint_trajectory_controller.cpp 83.48% <100.00%> (-0.05%) ⬇️
...ory_controller/test/test_trajectory_controller.cpp 99.74% <100.00%> (+<0.01%) ⬆️

... and 3 files with indirect coverage changes

@christophfroehlich christophfroehlich force-pushed the mergify/bp/iron/pr-1090 branch from 0a2bd6c to fe85da4 Compare May 22, 2024 19:34
@christophfroehlich christophfroehlich merged commit cb40e0b into iron May 22, 2024
10 of 11 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/iron/pr-1090 branch May 22, 2024 20:22
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants