Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(steering-odometry): convert twist to steering angle (backport #1288) #1295

Merged
merged 1 commit into from
Sep 26, 2024
+3 −6
Merged

fix(steering-odometry): convert twist to steering angle (backport #1288) #1295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions steering_controllers_library/src/steering_odometry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,12 +209,9 @@ void SteeringOdometry::set_odometry_type(const unsigned int type) { config_type_

double SteeringOdometry::convert_twist_to_steering_angle(double v_bx, double omega_bz)
{
if (fabs(v_bx) < std::numeric_limits<float>::epsilon())
{
// avoid division by zero
return 0.;
}
return std::atan(omega_bz * wheelbase_ / v_bx);
// phi can be nan if both v_bx and omega_bz are zero
const auto phi = std::atan(omega_bz * wheelbase_ / v_bx);
return std::isfinite(phi) ? phi : 0.0;
}

std::tuple<std::vector<double>, std::vector<double>> SteeringOdometry::get_commands(
Expand Down
Loading