Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -Wconversion flag to protect future developments (backport #667) #1321

Merged
merged 1 commit into from
Oct 26, 2024

Added -Wconversion flag and fix warnings (#667)

e20295e
Select commit
Loading
Failed to load commit list.
Merged

Add -Wconversion flag to protect future developments (backport #667) #1321

Added -Wconversion flag and fix warnings (#667)
e20295e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 26, 2024 in 0s

65.16% (-0.08%) compared to da5c15d

View this Pull Request on Codecov

65.16% (-0.08%) compared to da5c15d

Details

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.16%. Comparing base (da5c15d) to head (e20295e).

Files with missing lines Patch % Lines
tricycle_controller/src/tricycle_controller.cpp 60.00% 2 Missing ⚠️
tricycle_controller/src/traction_limiter.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1321      +/-   ##
==========================================
- Coverage   65.23%   65.16%   -0.08%     
==========================================
  Files         103      103              
  Lines       11437    11995     +558     
  Branches     7254     7398     +144     
==========================================
+ Hits         7461     7816     +355     
- Misses       1483     1544      +61     
- Partials     2493     2635     +142     
Files with missing lines Coverage Δ
...iff_drive_controller/src/diff_drive_controller.cpp 73.06% <100.00%> (+0.84%) ⬆️
...ontroller/test/test_forward_command_controller.cpp 57.89% <ø> (-1.39%) ⬇️
...est_multi_interface_forward_command_controller.cpp 62.50% <ø> (-1.91%) ⬇️
...include/joint_trajectory_controller/tolerances.hpp 80.86% <ø> (+0.68%) ⬆️
...ory_controller/src/joint_trajectory_controller.cpp 80.72% <ø> (+0.10%) ⬆️
tricycle_controller/src/traction_limiter.cpp 22.22% <0.00%> (+1.25%) ⬆️
tricycle_controller/src/tricycle_controller.cpp 66.18% <60.00%> (-0.79%) ⬇️

... and 77 files with indirect coverage changes