Add Mecanum Drive Controller (backport #512) #1376
Draft
+2,442
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 79358e3)
) (#1450) Co-authored-by: Shankar-Balajee <[email protected]>
|
are there any estimates on when this might be done? or on how much work there is, I can try to pick it up if I get the time and if no-one else is working on it |
|
@soham2560 yes please! Create PR(s) targeting this backport branch please. There were a few API changes in controller interface between humble and Jazzy. Those definitely need fixing for the build to pass. |
|
you can always compile the rolling version of the ros2_control stack on humble, see "development version" on https://control.ros.org/humble/doc/getting_started/getting_started.html#building-from-source |
Comment on lines
+46
to
+48
| Used when the controller is not in chained mode (``in_chained_mode == false``). | ||
|
|
||
| - <controller_name>/reference [geometry_msgs/msg/TwistStamped] |
There was a problem hiding this comment.
@soham2560 can you please fix this section? (you can add a review comment here, and I'll commit it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ros-controls/control_msgs#79
This is an automatic backport of pull request #512 done by Mergify.